Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json encoding bug #11159

Merged
merged 12 commits into from
Sep 25, 2024
Merged

Conversation

niklas-recordedfuture
Copy link
Contributor

@niklas-recordedfuture niklas-recordedfuture commented Sep 20, 2024

Change(s):

  • RecordedFuture-Alert-Importer: Add ?utm_source=recorded_future parameter to the external links that point to the recorded future app
  • RecordedFuture-Alert-Importer: Fix JSON serialization logic
  • RecordedFuture-Sandbox_Enrichment-Url: Use Sandbox connector instead of regular connector

Reason for Change(s):

  • Track where users are coming from in the recorded future app
  • Fix customer-reported bug with logic app JSON serialization
  • Fix customer-reported bug with logic app using the wrong connector by default

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • I'm getting some validation errors from unrelated files (can I run the tests only towards my solution somehow?)

@v-atulyadav v-atulyadav added Playbook Playbook specialty review needed Solution Solution specialty review needed labels Sep 20, 2024
There was a bug where if you had already instantiated something named "RecordedFuture-ConnectorV2" then it would use that, instead of asking you to create a new API connection for sandbox.
@niklas-recordedfuture niklas-recordedfuture marked this pull request as ready for review September 23, 2024 12:30
@v-prasadboke v-prasadboke merged commit e373814 into Azure:master Sep 25, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Playbook Playbook specialty review needed Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants